Skip to content

fix: prevent ambiguous slash phrases from rendering as file links#550

Merged
Dimillian merged 1 commit intoDimillian:mainfrom
alphali:fix/remark-file-links-slash-phrases
Mar 13, 2026
Merged

fix: prevent ambiguous slash phrases from rendering as file links#550
Dimillian merged 1 commit intoDimillian:mainfrom
alphali:fix/remark-file-links-slash-phrases

Conversation

@alphali
Copy link
Contributor

@alphali alphali commented Mar 12, 2026

Synopsis

CodexMonitor was incorrectly turning natural-language slash phrases like app/daemon,
Git/Plan, and Spec/Verification/Evidence into file links in rendered messages.

The raw agentMessage.text from thread/resume response was correct, so the issue was in
frontend markdown rendering, specifically the plain-text file linkification logic in
remarkFileLinks.

Before

  • natural-language slash phrases were rendered as file links
image

After

image

Changes

  • make plain-text file linkification more conservative
  • stop treating ambiguous slash phrases as file paths
  • keep explicit file-like paths such as docs/setup.md linkable
  • add regression tests for markdown rendering behavior

Validation

  • npm run test -- src/features/messages/components/Markdown.test.tsx
  • npm run typecheck
  • manual verification in npm run tauri:dev

@Samigos
Copy link
Contributor

Samigos commented Mar 13, 2026

Since you are on it, can you try fixing the bug where if a project name contains a space it doesn't render correctly on the message?

@Dimillian
Copy link
Owner

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. 🚀

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Dimillian Dimillian merged commit aecee91 into Dimillian:main Mar 13, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants